[feature] SC-166737/improve app proxy security by restricting where token replacements can go#75
Open
HappyPaul55 wants to merge 1 commit intomainfrom
Conversation
…oken replacements can go
|
Build for commit f77304b deployed to: https://wrike-pr-75.ci.next.deskprodemo.com URLs: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds settingsInjection configuration to the manifest.json to enable dynamic credential injection into API requests through the proxy whitelist, improving security by allowing sensitive credentials to be automatically injected rather than manually constructed in code.
- Added settings injection for the instance URL endpoint to inject
access_tokeninto the Authorization header - Added settings injection for the Wrike OAuth2 endpoint to inject
client_idandclient_secretinto request bodies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds settings injection functionality to the
manifest.jsonfile, allowing sensitive credentials to be dynamically injected into API requests. This improves security and flexibility for authentication and authorization.Settings injection for API requests:
settingsInjectionfor the__instance_url__endpoint, enabling theaccess_tokento be injected into theAuthorizationheader.settingsInjectionfor thehttps://login.wrike.com/oauth2/.*endpoint, enablingclient_idandclient_secretto be injected into the request body.